10/11: fix: helper edge case and typo#664
Merged
juleswritescode merged 2 commits intostacked/pr629-9-print-utilsfrom Jan 25, 2026
Merged
10/11: fix: helper edge case and typo#664juleswritescode merged 2 commits intostacked/pr629-9-print-utilsfrom
juleswritescode merged 2 commits intostacked/pr629-9-print-utilsfrom
Conversation
- return true when no previous sibling in previous_sibling_completed - fix delete -> delete_statement clause mapping - fix typo speciifcation -> specification
juleswritescode
changed the title
psteinroe
approved these changes
Jan 25, 2026
| "update" => Some(WrappingClause::Update), | ||
| "select" => Some(WrappingClause::Select), | ||
| "delete" => Some(WrappingClause::Delete), | ||
| "delete_statement" => Some(WrappingClause::Delete), |
Collaborator
There was a problem hiding this comment.
What's the difference between the names?
Collaborator
Author
There was a problem hiding this comment.
"delete" doesn't even exist as a node 🤷🏻
"delete_statement" should now be the parent of every statement starting with a delete keyword.
…ied (#660) ## Summary - Update all completion snapshots for keyword completions - Update grammar test snapshots for field name output - Remove #[ignore] attributes from tests - Update test helper ## Part of stacked PRs for #629 This is PR 11/11 in the keyword completion feature stack. --------- Co-authored-by: JulesWritesCode <julian.rechnungen@outlook.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
previous_sibling_completedto return true when no sibling existsPart of stacked PRs for #629
This is PR 10/11 in the keyword completion feature stack.