chore: Add http_route label to HTTP server metrics #2330
+75
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![depthfirst-app[bot]](https://avatars.githubusercontent.com/in/1021002?s=60&v=4){kind=small}
Pull Request Test Coverage Report for Build 21253676451Details
💛 - Coveralls |
jnschaeffer
force-pushed
the
chore/metric-tags
branch
2 times, most recently
from
26c6751 to
b810990
Compare
This commit adds the http_route label to HTTP server metrics, such as `http_server_request_duration_seconds_bucket`. This enables users to collect standard HTTP metrics per route rather than across all of Auth. Because `WithMetricAttributesFn` is only available in newer versions of otelhttp, this commit also upgrades the otelhttp package to v0.64.0. As a result, HTTP request metrics now use the newer `http_server_request_` naming convention rather than just `http_server_`.
This commit updates the semconv package to v1.38.0.
As described.
jnschaeffer
force-pushed
the
chore/metric-tags
branch
from
b810990 to
2aea070
Compare
cstockton
approved these changes
Jan 27, 2026
| return | ||
| } | ||
|
|
||
| defer func() { |
Contributor
There was a problem hiding this comment.
I think we should keep this defensive check here, it doesn't cost much.
| out := []attribute.KeyValue{ | ||
| routePatternAttr, | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
It's a nit, but the whitespace styling in places like this and the don't match the rest of the code base
| "go.opentelemetry.io/otel/trace" | ||
| ) | ||
|
|
||
| func getChiRoutePattern(r *http.Request) string { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR adds the
http_routelabel to standard HTTP server metrics collected by the otelhttp package. This enables users to collect HTTP metrics per route.Because
WithMetricAttributesFnis only available in newer versions of otelhttp, this commit also upgrades the otelhttp package to v0.63.0. As a result, HTTP request metrics now use the newerhttp_server_request_naming convention rather than justhttp_server_.What is the current behavior?
Currently, the
http_server_duration_milliseconds_bucketmetric does not include HTTP route labels. This means HTTP duration metrics are heavily skewed towards fast, frequently accessed API routes such as /user.What is the new behavior?
There are two changes introduced in this PR:
http_server_duration_milliseconds_bucketmetric is renamed tohttp_server_request_duration_seconds_buckethttp_server_request_duration_seconds_bucketmetric has an additional label,http_route, that matches thehttp_routelabel in thehttp_status_codes_totalmetric