fix: correctly parse JWT ValidMethods from env by enabling split_words #2334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
JWT ValidMethods not parsed from env because split_words was missing on the struct tag, causing envconfig to look for
GOTRUE_JWT_VALIDMETHODSinstead ofGOTRUE_JWT_VALID_METHODS. Since v2.71.1, cli defaults to asymmetric keys, which caused valid HS256 tokens to be rejected.What is the new behavior?
This change adds
split_wordsto ensure the correct env var is used. I assume thatGOTRUE_JWT_VALID_METHODSis the correct env var but if it isn't, then this issue can also be solved by updating the env var passed to auth service in supabase cli toAdditional context
The following screenshots are from print statements I added
config.JWT.ValidMethods was nil because it was looking for wrong env var. It defaulted to jwk key algorithm (ES256).
auth/internal/conf/configuration.go
Lines 1092 to 1097 in 645654d
After
