fix: stop requesting account_email by default for Kakao#2397
fix: stop requesting account_email by default for Kakao#2397heyman333 wants to merge 1 commit intosupabase:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Cache: Disabled due to Reviews > Disable Cache setting Disabled knowledge base sources:
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe changes modify the Kakao OAuth provider's default scopes by removing Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a9b20af to
8d848d4
Compare
|
Hi @heyman333 , thanks for the PR! I’m going to close this for now because removing The good news is we’re working on custom OAuth providers, which should go live next week in the Supabase Dashboard. With that, developers will be able to configure any OAuth/OIDC provider without requiring code changes on Supabase Auth side. Let me know if you're interested in testing it with Kakao. If so, you can create a ticket on https://supabase.help referring to this message and I'll take it from there! |
Summary
account_emailfrom the default Kakao OAuth scopesprofile_image,profile_nicknameaccount_emailis not requested by defaultWhy
account_emailconsent is available only for Kakao Business apps in many setups. Requesting it by default can break Kakao login for non-business apps.Testing
internal/api/provider/kakao_test.gointernal/api/external_kakao_test.go