Feat/enhance drop warning #3920
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--confirm-drops
option to control drop warning behavior--confirm-drops
: displays detailed warning and requires user confirmationMotivation
Currently,
supabase db diff
shows a very weak warning when DROP statements are detected.This is particularly problematic for column renames, which are detected as DROP COLUMN + ADD COLUMN operations, potentially causing data loss. #1721 (comment)
(I actually encountered this issue and it caused a major system failure. I am creating this Pull Request to prevent further victims.)
Changes
--confirm-drops
boolean flag to db diff command--confirm-drops
flag: Shows detailed danger warning with:Test plan
Example usage
Default behavior (simple warning)
Output:
With confirmation prompt
Output:
🤖 Generated with Claude Code