Skip to content

fix(deno): builder must detect DENO_NO_PACKAGE_JSON #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(deno): builder must detect DENO_NO_PACKAGE_JSON #619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion deno/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
use std::collections::HashMap;
use std::env;
use std::path::Path;
use std::path::PathBuf;
use std::sync::Arc;
Expand Down Expand Up @@ -243,7 +244,9 @@ impl DenoOptions {
});
let config_parse_options =
deno_config::deno_json::ConfigParseOptions::default();
let discover_pkg_json = config != ConfigMode::Disabled && !no_npm;
let discover_pkg_json = config != ConfigMode::Disabled
&& !no_npm
&& !has_flag_env_var("DENO_NO_PACKAGE_JSON");
if !discover_pkg_json {
log::debug!("package.json auto-discovery is disabled");
}
Expand Down Expand Up @@ -541,3 +544,8 @@ impl DenoOptionsBuilder {
DenoOptions::from_builder(self)
}
}

pub fn has_flag_env_var(name: &str) -> bool {
let value = env::var(name);
matches!(value.as_ref().map(|s| s.as_str()), Ok("1"))
}
Loading