ref(streaming): Refine timeout stream behavior #479
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refines the
TimeoutStreambehavior to correctly exhibit the intended timeout semantics. Previously, the timer only started when the inner stream returnedPending. Now the timer starts immediately when reset, giving us a fixed window per batch.The semantics are:
max_batch_fill_durationand the stream goes idle, we emit a timeout.This prevents the timeout from interrupting a healthy stream that happens to be slow, while still guaranteeing we flush partial batches when the source truly goes quiet.