feat(api): Add source validation endpoint#641
Merged
iambriccardo merged 3 commits intomainfrom Mar 26, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new ETL API endpoint to validate a source configuration (similar to existing destination/pipeline validation) and returns structured validation failures instead of rejecting the request.
Changes:
- Introduces
POST /v1/sources/validatewithValidateSourceRequest/ResponseandValidationFailureResponse. - Wires the new endpoint + OpenAPI schemas into the Actix server startup.
- Extends the test harness and adds integration tests for trusted-username validation behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
etl-api/src/routes/sources.rs |
Adds request/response types and the validate_source route implementation. |
etl-api/src/startup.rs |
Registers the new route and includes schemas/paths in OpenAPI. |
etl-api/tests/support/test_app.rs |
Adds a validate_source helper for authenticated test requests. |
etl-api/tests/sources.rs |
Adds integration tests covering success/failure cases for source validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bnjjj
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an endpoint to perform source validation given a config. It makes sure that the supplied source config is usable from the ETL API.