Skip to content

Conversation

kakeluh
Copy link
Contributor

@kakeluh kakeluh commented Feb 8, 2025

What kind of change does this PR introduce?

Specify the type definitions of tables used as return types, parameters and composite type's attributes.

What is the current behavior?

What is the new behavior?

no more unknown on the tables.

Additional context

/types endpoint only returns composites and enums, so I didn't add the query parameter to src/server/routes/types.ts.

Sorry for my poor English.

@kakeluh kakeluh requested review from a team as code owners February 8, 2025 19:05
Copy link
Member

@kamilogorek kamilogorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13218477497

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 5 (80.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 75.139%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/server/server.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 13160620906: 0.02%
Covered Lines: 4851
Relevant Lines: 6372

💛 - Coveralls

@soedirgo
Copy link
Member

Thanks @kakeluh!

@soedirgo soedirgo merged commit 8418eaa into supabase:master Feb 13, 2025
5 checks passed
@Donnerstagnacht
Copy link

@kakeluh Thanks!

Any chance you could have a look at #842 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants