Skip to content

fix: this end is not a function error #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2025
Merged

fix: this end is not a function error #925

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02fd305
fix: this.end is not a function error
avallete Apr 8, 2025
21d100f
fix: use bind and catch unexpected error
avallete Apr 8, 2025
023675d
Merge branch 'master' into fix/this-end-is-not-a-function-error
avallete Apr 8, 2025
2b6259d
chore: reduce try/catch to minimal level
avallete Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/lib/db.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,13 @@ ${' '.repeat(5 + lineNumber.toString().length + 2 + lineOffset)}^
}
return { data: null, error: { code: error.code, message: error.message } }
} finally {
// If the error isn't a "DatabaseError" assume it's a connection related we kill the connection
// To attempt a clean reconnect on next try
await this.end()
try {
// If the error isn't a "DatabaseError" assume it's a connection related we kill the connection
// To attempt a clean reconnect on next try
await this.end.bind(this)
} catch (error) {
console.error('Failed to end the connection on error: ', { this: this, end: this.end })
}
}
}
},
Expand Down