Skip to content

Conversation

darora
Copy link
Contributor

@darora darora commented Sep 2, 2024

Adds a number of Postgrest response types for compression by Envoy.

@darora darora requested a review from a team as a code owner September 2, 2024 00:39
@istarkov
Copy link

istarkov commented Sep 2, 2024

I can confirm that it works now, given that these changes have been applied to our Supabase project.

However, I noticed that all other responses previously used Brotli compression by default, but now they are using gzip.
Support Ticket ID: 3125882163 / Discussion

It’s not a big deal, but Brotli is more commonly used than gzip in our infrastructure.
Anyway, we’ve excluded the use of .single() in our code, so we’ll be able to compare the difference between gzip and Brotli using our stats, if it exists and is statistically significant.

@supa-alex supa-alex force-pushed the da/pgrst-response-types branch from fb98254 to ef84bf3 Compare September 11, 2024 06:05
Adds a number of Postgrest response types for compression by Envoy, enables gzip and brotli compression, and defaults to `br` compression (e.g. for `Accept-Encoding: *`).
@darora darora force-pushed the da/pgrst-response-types branch from ef84bf3 to 8a89aaa Compare September 11, 2024 06:59
@darora
Copy link
Contributor Author

darora commented Sep 11, 2024

We're looking into updating out Cloudflare configuration to prefer using Brotli. In the meantime, we'll be merging this in to have the docker images updated.

@darora darora merged commit d2fd531 into develop Sep 11, 2024
9 checks passed
@darora darora deleted the da/pgrst-response-types branch September 11, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants