Skip to content

Conversation

samrose
Copy link
Collaborator

@samrose samrose commented Sep 10, 2024

What kind of change does this PR introduce?

  • bumping the git revision of nixpkgs to the latest rev or nixpkgs-unstable
  • Bringing packaging of postgresql and a dependency into our codebase, so that we can control the build, dependencies, and minor version changes independent of what is happening in nixpkgs
  • for running on darwin, needed some env vars for PGPORT during the build phase
  • introducing postgresql_16, but not yet incorporating it into the installables available from the flake
  • advanced postgresql minor version to "15.8"

@olirice
Copy link
Contributor

olirice commented Sep 11, 2024

sorry in advance for the hassle but could we do this in 3 separate PRs?

  • PR1 - Bringing packaging of postgresql and a dependency into our codebase
  • PR2 - advanced postgresql minor version to "15.8"
  • PR3 - introducing postgresql_16, but not yet incorporating it into the installables available from the flake

at this phase we're frequently using your PRs to identify where to look to handle these types of tasks and having them separate would make that easier so e.g. any on the team would know how to add pg17

@samrose
Copy link
Collaborator Author

samrose commented Sep 11, 2024

Yes of course seems well reasoned to me. I’ll close this and follow up with those PR

@samrose samrose closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants