feat: control shared_buffers value if oriole prior to start #1343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darora
approved these changes
Nov 28, 2024
| update_orioledb_buffers "$shared_buffers_value" | ||
|
|
||
| # Update shared_buffers during alpha release to 32MB | ||
| # TODO will need to add logic here for different ec2 sizes |
There was a problem hiding this comment.
Let's not duplicate that logic here. The right place to do it is in the internal binary that already generates these for our current setup.
There was a problem hiding this comment.
@darora ok I will look into how to add that appropriately in admin-api closing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
oriole needs different shared_buffer treatment/lower value, so for now we'll detect and set oriole to 32MB shared_buffers.
Once we have multiple sizes available, we'll check instance size and stagger it.