Skip to content

feat: update envoy lds with origin protection keys #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2025
Merged

feat: update envoy lds with origin protection keys #1403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions ansible/files/envoy_config/lds.supabase.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,25 @@ resources:
name: ':path'
string_match:
contains: apikey=supabase_admin_key
origin_protection_key_missing:
permissions:
- any: true
principals:
- not_id:
header:
name: sb-opk
present_match: true
origin_protection_key_not_valid:
permissions:
- any: true
principals:
- not_id:
or_ids:
ids:
Comment on lines +98 to +99
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for not doing a direct comparison here rather than an array check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There can be multiple keys here, coming from the trusted_keys column, to enable easy rotation.

- header:
name: sb-opk
string_match:
exact: supabase_origin_protection_key
- name: envoy.filters.http.lua
typed_config:
'@type': >-
Expand Down
6 changes: 3 additions & 3 deletions ansible/vars.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ postgres_major:

# Full version strings for each major version
postgres_release:
postgresorioledb-17: "17.0.1.016-orioledb"
postgres15: "15.8.1.026"
postgres16: "16.3.1.032"
postgresorioledb-17: "17.0.1.017-orioledb"
postgres15: "15.8.1.027"
postgres16: "16.3.1.033"

# Non Postgres Extensions
pgbouncer_release: "1.19.0"
Expand Down
Loading