Skip to content

Conversation

samrose
Copy link
Collaborator

@samrose samrose commented Mar 12, 2025

What kind of change does this PR introduce?

xmrig is apparently an official nix package https://github.com/NixOS/nixpkgs/blob/nixpkgs-unstable/nixos/modules/services/misc/xmrig.nix

It is normal when installing a nix package, for nix to download the whole nix language package definition source code for all of the packages available in nixpkgs. However, only the executable binaries that you explicitly install are actually present.

Never the less, this pr sets the attribute for xmrig package to "throw", and runs garbage collect after install to remove any unrelated source , although the executable was NEVER installed or running at any time.

@samrose samrose requested a review from a team as a code owner March 12, 2025 01:16
@samrose
Copy link
Collaborator Author

samrose commented Mar 12, 2025

We're going to test this in CLI before merging and releasing, as the changes could impact cli/local dev users. Running nix garbage collect should have no impact, but we'll test that now to assure cli users have no issue.

@samrose samrose changed the title chore: rm xmrig src by setting attribute to null chore: rm xmrig src by setting attribute to throw Mar 12, 2025
@samrose samrose merged commit d65e484 into develop Mar 12, 2025
12 checks passed
@samrose samrose deleted the sam/null-xmrig-src branch March 12, 2025 13:11
damonrand pushed a commit to cepro/postgres that referenced this pull request Jun 15, 2025
* chore: rm xmrig src by setting attribute to null

* chore: garbage collect drops source for unused packages

* chore: testing id for docker image

* chore: bump release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants