chore: rm xmrig src by setting attribute to throw #1473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darora
approved these changes
Mar 12, 2025
steve-chavez
approved these changes
Mar 12, 2025
|
We're going to test this in CLI before merging and releasing, as the changes could impact cli/local dev users. Running nix garbage collect should have no impact, but we'll test that now to assure cli users have no issue. |
samrose
changed the title
damonrand
pushed a commit
to cepro/postgres
that referenced
this pull request
Jun 15, 2025
* chore: rm xmrig src by setting attribute to null * chore: garbage collect drops source for unused packages * chore: testing id for docker image * chore: bump release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
xmrig is apparently an official nix package https://github.com/NixOS/nixpkgs/blob/nixpkgs-unstable/nixos/modules/services/misc/xmrig.nix
It is normal when installing a nix package, for nix to download the whole nix language package definition source code for all of the packages available in nixpkgs. However, only the executable binaries that you explicitly install are actually present.
Never the less, this pr sets the attribute for xmrig package to "throw", and runs garbage collect after install to remove any unrelated source , although the executable was NEVER installed or running at any time.