test: role privileges on auth/storage db objects #1577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-chavez
commented
Apr 30, 2025
Comment on lines
+70
to
+78
| schema_name | table_name | role_name | privilege_type | is_grantable | ||
| -------------+-------------------+---------------------+----------------+-------------- | ||
| auth | audit_log_entries | dashboard_user | DELETE | f | ||
| auth | audit_log_entries | dashboard_user | INSERT | f | ||
| auth | audit_log_entries | dashboard_user | REFERENCES | f | ||
| auth | audit_log_entries | dashboard_user | SELECT | f | ||
| auth | audit_log_entries | dashboard_user | TRIGGER | f | ||
| auth | audit_log_entries | dashboard_user | TRUNCATE | f | ||
| auth | audit_log_entries | dashboard_user | UPDATE | f |
There was a problem hiding this comment.
Note: these privileges could be compressed to a single line with array_agg, like:
schema_name | table_name | role_name | privilege_types | is_grantable
-------------+-------------------+---------------------+-----------------------------------------------------------+-----------------
auth | audit_log_entries | dashboard_user | {DELETE,INSERT,REFERENCES,SELECT,TRIGGER,TRUNCATE,UPDATE} | {f,f,f,f,f,f,f}
auth | audit_log_entries | postgres | {DELETE,INSERT,REFERENCES,SELECT,TRIGGER,TRUNCATE,UPDATE} | {f,f,f,f,f,f,f}
auth | audit_log_entries | supabase_auth_admin | {DELETE,INSERT,REFERENCES,SELECT,TRIGGER,TRUNCATE,UPDATE} | {f,f,f,f,f,f,f}
But then once a test fails is hard to visualize the privileges diff. (case in point: just happened to me with the new MAINTAIN privilege on pg 17, had a previous version with compressed privs and that was hard to visualize, wasted some time there).
olirice
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We're currently lacking these tests so we don't know the effects of other PRs that modify them. See #994.