fix: changes to envoy external ip headers for use by auth rate limiting #1593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Added new external IP to envoy external IP. This is the IP before the last hop based on the x-forwarded-for header.
What is the current behavior?
Currently Envoy acts transparently in regards to x-forwarded-for headers, does not add or delete.
What is the new behavior?
envoy will append a new x-envoy-external-address header that will only include the IP address of before that last hop (i.e. the client before the ALB)
Additional context
Please see internal infra discussion on this vs at the auth layer