Skip to content

Conversation

jgoux
Copy link
Contributor

@jgoux jgoux commented May 21, 2025

What kind of change does this PR introduce?

Fixes DEVWF-427

What is the current behavior?

In the self-hosting use case, when the $POSTGRES_PASSWORD is changed, the change isn't synced to all the supabase roles when the container is restarted.

What is the new behavior?

The $POSTGRES_PASSWORD change is properly propagated to the supabase roles.

Additional context

@jgoux jgoux marked this pull request as ready for review May 21, 2025 15:56
@jgoux jgoux requested review from a team as code owners May 21, 2025 15:56
@jgoux jgoux requested a review from sweatybridge May 21, 2025 16:12
@jgoux jgoux merged commit 905c9f2 into develop May 22, 2025
14 checks passed
@jgoux jgoux deleted the jgoux/fix-password-update branch May 22, 2025 06:53
EOSQL

# execute the roles SQL file using docker_process_sql
docker_process_sql -f /docker-entrypoint-initdb.d/init-scripts/99-roles.sql
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgoux let's make this path an env var and only run pg_sync_password if this path is defined.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'll make the change 👍

damonrand pushed a commit to cepro/postgres that referenced this pull request Jun 15, 2025
* fix: sync supabase roles with $POSTGRES_PASSWORD

* add changes to pg 17 Dockerfile

* add changes to oriole docker image

* Update docker-entrypoint.sh

---------

Co-authored-by: Bobbie Soedirgo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants