-
-
Notifications
You must be signed in to change notification settings - Fork 217
feat: support multiple versions of the pgroonga extension #1677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d4dcb3 to
4849d1b
Compare
hunleyd
previously requested changes
Aug 27, 2025
Contributor
hunleyd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebase to fix conflicts?
4849d1b to
3d18ed9
Compare
a4e51a1 to
3355603
Compare
5 tasks
Build multiple versions of the pgroonga extension on different PostgreSQL versions. Add test for the extensions and their upgrade on PostgreSQL 15 and 17.
Moved sfcgal and mecab-naist-jdic from nix/ext to nix/packages.
b5466f0 to
2c75e72
Compare
Thanks for your review. rebase was a success. dismissing only to unblock, and approving to merge
samrose
approved these changes
Oct 24, 2025
hunleyd
added a commit
that referenced
this pull request
Oct 27, 2025
* origin/develop: chore: add our substituter config to flake.nix (#1839) refactor: improve test harness logging and error handling (#1834) feat: support multiple versions of the pgroonga extension (#1677) refactor(ansible): bring our ansible up to modern ansible-lint standards (#1862) fix: bump version for new release (#1860)
encima
pushed a commit
that referenced
this pull request
Oct 28, 2025
* feat: support multiple versions of the pgroonga extension Build multiple versions of the pgroonga extension on different PostgreSQL versions. Add test for the extensions and their upgrade on PostgreSQL 15 and 17. * refactor(nix): make sure ext contains only extensions Moved sfcgal and mecab-naist-jdic from nix/ext to nix/packages. * feat: resolve a few issues with tests and integration with tooling * fix: make sure that docker image has full/correct groonga/pgroonga handling * chore: bump version to release --------- Co-authored-by: Sam Rose <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build multiple versions of the pgroonga extension on different PostgreSQL versions. Add test for the extensions and their upgrade on PostgreSQL 15 and 17
also includes
Fix Groonga/PGroonga Installation in Dockerfiles
Summary
aligns the groonga/pgroonga installation approach in Dockerfiles with the Ansible deployment method, ensuring consistent behavior across different deployment strategies.
Problem
There was an inconsistency in how groonga and pgroonga packages were being installed between Ansible-based deployments and Docker-based deployments:
Ansible Approach (Correct)
supabase-groongaas a separate Nix packageGRN_PLUGINS_DIRenvironment variable pointing to/var/lib/postgresql/.nix-profile/lib/groonga/pluginsDockerfile Approach (Incorrect)
GRN_PLUGINS_DIRenvironment variableChanges
Files Modified
Dockerfile-15Dockerfile-17Dockerfile-orioledb-17What Was Changed
For each Dockerfile:
Added dedicated groonga build stage (after the
walgstage):Copy groonga plugins to production image:
COPY --from=groonga /tmp/groonga-plugins/plugins /usr/lib/groonga/pluginsSet GRN_PLUGINS_DIR environment variable:
ENV GRN_PLUGINS_DIR=/usr/lib/groonga/pluginsThis fix ensures that the pgroonga extension (configured in
ansible/files/postgresql_config/supautils.conf.j2) will work correctly in Docker-based deployments, matching the behavior of Ansible-based deployments.