-
-
Notifications
You must be signed in to change notification settings - Fork 201
fix(ext/wrappers): restore backward compatibility files for postgres upgrade #1729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upgrade Postgres upgrade is failing due to missing files in the wrappers. Refactor extension build to move file creation from individual builds to the final buildEnv stage, ensuring all version-specific library symlinks and migration SQL files are properly included for postgres upgrades. <details> <summary>Files present in the extension before upgrading the extension</summary> ```bash $ nix build -L github:supabase/postgres/4db4d5b94269398dc167fe96ea43fc4336bff8b5\#packages.x86_64-linux.psql_15/exts/supabase-wrappers $ tree result result/ ├── lib │ ├── wrappers-0.1.0.so -> wrappers.so │ ├── wrappers-0.1.10.so -> wrappers.so │ ├── wrappers-0.1.11.so -> wrappers.so │ ├── wrappers-0.1.12.so -> wrappers.so │ ├── wrappers-0.1.14.so -> wrappers.so │ ├── wrappers-0.1.15.so -> wrappers.so │ ├── wrappers-0.1.16.so -> wrappers.so │ ├── wrappers-0.1.17.so -> wrappers.so │ ├── wrappers-0.1.18.so -> wrappers.so │ ├── wrappers-0.1.19.so -> wrappers.so │ ├── wrappers-0.1.1.so -> wrappers.so │ ├── wrappers-0.1.4.so -> wrappers.so │ ├── wrappers-0.1.5.so -> wrappers.so │ ├── wrappers-0.1.6.so -> wrappers.so │ ├── wrappers-0.1.7.so -> wrappers.so │ ├── wrappers-0.1.8.so -> wrappers.so │ ├── wrappers-0.1.9.so -> wrappers.so │ ├── wrappers-0.2.0.so -> wrappers.so │ ├── wrappers-0.3.0.so -> wrappers.so │ ├── wrappers-0.3.1.so -> wrappers.so │ ├── wrappers-0.4.0.so -> wrappers.so │ ├── wrappers-0.4.1.so -> wrappers.so │ ├── wrappers-0.4.2.so -> wrappers.so │ ├── wrappers-0.4.3.so -> wrappers.so │ ├── wrappers-0.4.4.so -> wrappers.so │ ├── wrappers-0.4.5.so -> wrappers.so │ ├── wrappers-0.4.6.so -> wrappers.so │ ├── wrappers-0.5.0.so -> wrappers.so │ └── wrappers.so └── share └── postgresql └── extension ├── wrappers--0.1.0--0.5.0.sql ├── wrappers--0.1.10--0.5.0.sql ├── wrappers--0.1.1--0.5.0.sql ├── wrappers--0.1.11--0.5.0.sql ├── wrappers--0.1.12--0.5.0.sql ├── wrappers--0.1.14--0.5.0.sql ├── wrappers--0.1.15--0.5.0.sql ├── wrappers--0.1.16--0.5.0.sql ├── wrappers--0.1.17--0.5.0.sql ├── wrappers--0.1.18--0.5.0.sql ├── wrappers--0.1.19--0.5.0.sql ├── wrappers--0.1.4--0.5.0.sql ├── wrappers--0.1.5--0.5.0.sql ├── wrappers--0.1.6--0.5.0.sql ├── wrappers--0.1.7--0.5.0.sql ├── wrappers--0.1.8--0.5.0.sql ├── wrappers--0.1.9--0.5.0.sql ├── wrappers--0.2.0--0.5.0.sql ├── wrappers--0.3.0--0.5.0.sql ├── wrappers--0.3.1--0.5.0.sql ├── wrappers--0.4.0--0.5.0.sql ├── wrappers--0.4.1--0.5.0.sql ├── wrappers--0.4.2--0.5.0.sql ├── wrappers--0.4.3--0.5.0.sql ├── wrappers--0.4.4--0.5.0.sql ├── wrappers--0.4.5--0.5.0.sql ├── wrappers--0.4.6--0.5.0.sql ├── wrappers--0.5.0.sql └── wrappers.control 5 directories, 58 files ``` </details> <details> <summary>Files present in the extension after upgrading the extension (after #1663 was merged)</summary> ```bash $ nix build -L github:supabase/postgres/develop\#packages.x86_64-linux.psql_15/exts/wrappers-all $ tree result result/ ├── lib │ ├── wrappers-0.5.3.so -> /nix/store/g84xfq2m4wrxwsrh63yrs4df44bwj52b-wrappers-0.5.3/lib/wrappers-0.5.3.so │ └── wrappers.so -> /nix/store/g84xfq2m4wrxwsrh63yrs4df44bwj52b-wrappers-0.5.3/lib/wrappers.so └── share └── postgresql └── extension ├── wrappers--0.5.3.control -> /nix/store/g84xfq2m4wrxwsrh63yrs4df44bwj52b-wrappers-0.5.3/share/postgresql/extension/wrappers--0.5.3.control ├── wrappers--0.5.3.sql -> /nix/store/g84xfq2m4wrxwsrh63yrs4df44bwj52b-wrappers-0.5.3/share/postgresql/extension/wrappers--0.5.3.sql └── wrappers.control -> /nix/store/g84xfq2m4wrxwsrh63yrs4df44bwj52b-wrappers-0.5.3/share/postgresql/extension/wrappers.control 5 directories, 5 files ``` </details> <details> <summary>Files present in the extension with this commit</summary> ```bash $ nix build -L .\#packages.x86_64-linux.psql_15/exts/wrappers-all $ tree result result/ ├── lib │ ├── wrappers-0.1.0.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.1.10.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.1.11.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.1.12.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.1.14.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.1.15.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.1.16.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.1.17.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.1.18.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.1.19.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.1.1.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.1.4.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.1.5.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.1.6.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.1.7.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.1.8.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.1.9.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.2.0.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.3.0.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.3.1.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.4.0.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.4.1.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.4.2.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.4.3.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.4.4.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.4.5.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.4.6.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.5.0.so -> /nix/store/w6yr0d0v8hxm32z1lh3p4m09gayli1sh-wrappers/lib/wrappers.so │ ├── wrappers-0.5.3.so -> /nix/store/m15jazn3jznd17naihs4w413r2wdwzpz-wrappers-0.5.3/lib/wrappers-0.5.3.so │ └── wrappers.so -> wrappers-0.5.3.so └── share └── postgresql └── extension ├── wrappers--0.1.0--0.5.3.sql ├── wrappers--0.1.10--0.5.3.sql ├── wrappers--0.1.1--0.5.3.sql ├── wrappers--0.1.11--0.5.3.sql ├── wrappers--0.1.12--0.5.3.sql ├── wrappers--0.1.14--0.5.3.sql ├── wrappers--0.1.15--0.5.3.sql ├── wrappers--0.1.16--0.5.3.sql ├── wrappers--0.1.17--0.5.3.sql ├── wrappers--0.1.18--0.5.3.sql ├── wrappers--0.1.19--0.5.3.sql ├── wrappers--0.1.4--0.5.3.sql ├── wrappers--0.1.5--0.5.3.sql ├── wrappers--0.1.6--0.5.3.sql ├── wrappers--0.1.7--0.5.3.sql ├── wrappers--0.1.8--0.5.3.sql ├── wrappers--0.1.9--0.5.3.sql ├── wrappers--0.2.0--0.5.3.sql ├── wrappers--0.3.0--0.5.3.sql ├── wrappers--0.3.1--0.5.3.sql ├── wrappers--0.4.0--0.5.3.sql ├── wrappers--0.4.1--0.5.3.sql ├── wrappers--0.4.2--0.5.3.sql ├── wrappers--0.4.3--0.5.3.sql ├── wrappers--0.4.4--0.5.3.sql ├── wrappers--0.4.5--0.5.3.sql ├── wrappers--0.4.6--0.5.3.sql ├── wrappers--0.5.0--0.5.3.sql ├── wrappers--0.5.3.control -> /nix/store/m15jazn3jznd17naihs4w413r2wdwzpz-wrappers-0.5.3/share/postgresql/extension/wrappers--0.5.3.control ├── wrappers--0.5.3.sql -> /nix/store/m15jazn3jznd17naihs4w413r2wdwzpz-wrappers-0.5.3/share/postgresql/extension/wrappers--0.5.3.sql └── wrappers.control 5 directories, 61 files ``` </details>
tomashley
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres upgrade is failing due to missing files in the wrappers.
Refactor extension build to move file creation from individual builds to the final buildEnv stage, ensuring all version-specific library symlinks and migration SQL files are properly included for postgres upgrade.
Files present in the extension before upgrading the extension
Files present in the extension after upgrading the extension (after #1663 was merged)
Files present in the extension with this commit