Skip to content

Update supautils.conf.j2 | removed users permission to update log_sta… #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

TheOtherBrian1
Copy link
Contributor

What kind of change does this PR introduce?

Modifies supautils.

What is the current behavior?

Users can change log_statements

What is the new behavior?

Revokes users' permission to change the log_statements

Additional context

log_statements should be set to ddl. It was assumed that users would expand it to ddl, write,..., but not remove the default setting. A Team Customer's instance had a setting of none. As a result, uncovering why objects have been dropped has become nearly impossible.

Ensuring DDL commands are logged is essential for both users and Support for uncovering hacks, rogue AI queries, and internal vandalism between project owners.

Add any other context or screenshots.

@TheOtherBrian1 TheOtherBrian1 requested review from a team as code owners August 4, 2025 22:14
@soedirgo
Copy link
Member

soedirgo commented Aug 5, 2025

This is a difficult move to justify because it's a breaking change and it prevents higher levels of logging (which may in turn result in more tickets). Looking into the ticket to get more details

@steve-chavez
Copy link
Member

The ideal solution would be to disable the none value instead. supautils has a feature that disable values for GUC placeholders (ref1 and ref2), but this won't work for already defined GUCs IINM. We would need to see if that can be made to work somehow.

@soedirgo
Copy link
Member

soedirgo commented Aug 6, 2025

The ideal solution would be to disable the none value instead

It'd still be a breaking change.

Root cause has been addressed in the linked ticket, so closing this.

@soedirgo soedirgo closed this Aug 6, 2025
@soedirgo soedirgo deleted the TheOtherBrian1-patch-1 branch August 6, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants