Skip to content

Conversation

samrose
Copy link
Collaborator

@samrose samrose commented Aug 7, 2025

What kind of change does this PR introduce?

pg_cron multi version following the new nix code pattern

Copy link
Collaborator

@jfroche jfroche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For other extensions which require other file than the nix file, we move the extension package into <package name>/default.nix.
So nix/ext/pg_cron.nix would become nix/ext/pg_cron/default.nix.
Maybe it is the right moment to do so here too.

Copy link
Collaborator

@jfroche jfroche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add the nixos test to verify the extension migration between versions as well as the postgresql upgrade like we did in pg_net.

@samrose samrose force-pushed the multi-version-ext/pg-cron branch from 7da142e to 2459d95 Compare September 4, 2025 18:15
@samrose samrose marked this pull request as ready for review September 5, 2025 01:07
@samrose samrose requested review from a team as code owners September 5, 2025 01:07
@samrose
Copy link
Collaborator Author

samrose commented Sep 5, 2025

Passed all pause/restore, upgrade and functional tests.

@samrose samrose requested a review from jfroche September 5, 2025 12:51
@samrose samrose merged commit fae5be1 into develop Sep 5, 2025
6 checks passed
@samrose samrose deleted the multi-version-ext/pg-cron branch September 5, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants