-
-
Notifications
You must be signed in to change notification settings - Fork 209
Multi version ext/pg cron #1737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For other extensions which require other file than the nix file, we move the extension package into <package name>/default.nix
.
So nix/ext/pg_cron.nix
would become nix/ext/pg_cron/default.nix
.
Maybe it is the right moment to do so here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also add the nixos test to verify the extension migration between versions as well as the postgresql upgrade like we did in pg_net.
886a86b
to
b4d91c6
Compare
3cc4e7c
to
7da142e
Compare
Fix upgrade nixos tests that was broken. Move overlays and switch-ext-version script to package.
Keep the postgres extension tests DRY by extracting shared logic into a shared library.
7da142e
to
2459d95
Compare
Passed all pause/restore, upgrade and functional tests. |
What kind of change does this PR introduce?
pg_cron multi version following the new nix code pattern