fix: set max socket message queue length #1547
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgurgel
reviewed
Sep 30, 2025
filipecabaco
force-pushed
the
fix/set-max-websocket-messages
branch
from
721f5ca to
0fd1e36
Compare
We're using the event to update the counter to check if the websocket has too many messages. If so we will consider abusive behaviour and will kill the socket to prevent further damage.
filipecabaco
force-pushed
the
fix/set-max-websocket-messages
branch
2 times, most recently
from
8345e72 to
ba63e09
Compare
edgurgel
reviewed
Oct 6, 2025
filipecabaco
force-pushed
the
fix/set-max-websocket-messages
branch
from
ba63e09 to
98d479d
Compare
filipecabaco
force-pushed
the
fix/set-max-websocket-messages
branch
from
98d479d to
c16e06c
Compare
|
Currently this will bring more complexity with less gains so we're not moving forward with it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
We're using the event to update the counter to check if the websocket has too many messages. If so we will consider abusive behaviour and will kill the socket to prevent further damage.