Skip to content

Comments

fix: normalize booleans on join payloads#1690

Merged
filipecabaco merged 2 commits intomainfrom
fix/infer-boolean-strings-join-payload
Feb 3, 2026
Merged

fix: normalize booleans on join payloads#1690
filipecabaco merged 2 commits intomainfrom
fix/infer-boolean-strings-join-payload

Conversation

@filipecabaco
Copy link
Member

What kind of change does this PR introduce?

To ensure better compatibility with existing users we will infer intent from non boolean values by normalizing and down casing boolean strings

e.g. 'False' will be considered false boolean value

@filipecabaco filipecabaco force-pushed the fix/infer-boolean-strings-join-payload branch from cc483f7 to be13b40 Compare January 30, 2026 16:35
@coveralls
Copy link

coveralls commented Jan 30, 2026

Coverage Status

coverage: 88.657% (+0.06%) from 88.596%
when pulling 7387ce0 on fix/infer-boolean-strings-join-payload
into e86e984 on main.

@filipecabaco filipecabaco force-pushed the fix/infer-boolean-strings-join-payload branch 2 times, most recently from 7387ce0 to 0b8f978 Compare February 2, 2026 23:53
Copy link
Member

@edgurgel edgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

To ensure better compatibility with existing users we will infer intent from non boolean values by normalizing and downcasing boolean strings

e.g. False will be considered false boolean value
@filipecabaco filipecabaco force-pushed the fix/infer-boolean-strings-join-payload branch from 0b8f978 to 3f17c80 Compare February 3, 2026 10:40
@filipecabaco filipecabaco merged commit 0861a82 into main Feb 3, 2026
6 of 7 checks passed
@filipecabaco filipecabaco deleted the fix/infer-boolean-strings-join-payload branch February 3, 2026 12:21
@kiwicopple
Copy link
Member

🎉 This PR is included in version 2.74.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants