fix: reduce conflicts on load aware node selection#1694
Merged
Conversation
edgurgel
force-pushed
the
fix/region-aware-load-conflicts
branch
from
76fbc1a to
38fe7c0
Compare
The algorithm has been changed to use a time-bucketed seeded random node selection. Also changed to the algorithm to always pick two different nodes If both nodes did not return a load to be used we just fallback to the original algorithm to use phash2 on the tenant id for the index
edgurgel
force-pushed
the
fix/region-aware-load-conflicts
branch
from
38fe7c0 to
449827f
Compare
filipecabaco
approved these changes
Feb 3, 2026
Member
|
🎉 This PR is included in version 2.74.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
The goal here is to reduce syn conflicts.
The algorithm has been changed to use a time-bucketed seeded random node selection. Time-bucketed makes sense here because the load average 5m shouldn't change much in 1 minute (default time bucket).
Also changed to the algorithm to always pick two different nodes.
If both nodes did not return their load number we just fallback to the original algorithm to use
phash2on the tenant id for the selection.