fix: prevent crash when logging channel termination reason#1696
Merged
edgurgel merged 1 commit intosupabase:mainfrom Feb 4, 2026
Merged
fix: prevent crash when logging channel termination reason#1696edgurgel merged 1 commit intosupabase:mainfrom
edgurgel merged 1 commit intosupabase:mainfrom
Conversation
Member
|
🎉 This PR is included in version 2.74.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix to prevent crash when logging channel termination reason.
What is the current behavior?
An error is thrown when logging the termination reason if it's a tuple (e.g.
{:shutdown, :left}).What is the new behavior?
The logging adopts the same convention as other Phoenix
terminatehandlers usinginspect.Additional context
We observed frequent GenServer crashes on channel disconnects. My troubleshooting identified this log line as the culprit.