fix: ensure Watchdog kills ReplicationConnection on failing healthcheck#1763
Merged
fix: ensure Watchdog kills ReplicationConnection on failing healthcheck#1763
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes ReplicationConnection watchdog behavior so unresponsive replication connections are actively terminated, while simplifying initialization by removing the Wrapper GenServer and relying on Postgrex/DBConnection timeouts.
Changes:
- Update Watchdog to terminate the ReplicationConnection when health checks time out.
- Remove the ReplicationConnection Wrapper GenServer and introduce
query_timeout-driven query timeouts during initialization steps. - Update tests and bump Postgrex (and related) dependencies.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
lib/realtime/tenants/replication_connection/watchdog.ex |
On health-check timeout, logs and triggers termination of the replication connection. |
lib/realtime/tenants/replication_connection.ex |
Removes wrapper-based init timeout, adds query_timeout, adds stop/2, and applies timeouts to init queries. |
test/realtime/tenants/replication_connection_test.exs |
Adds watchdog regression test, adjusts timeout test, removes Mimic usage, and improves assert_process_down/2. |
mix.exs |
Bumps Postgrex requirement to ~> 0.21.0. |
mix.lock |
Locks updated versions for postgrex, db_connection, and telemetry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
filipecabaco
approved these changes
Mar 20, 2026
edgurgel
force-pushed
the
fix/replication-watchdog
branch
from
16b5186 to
0290beb
Compare
|
🎉 This PR is included in version 2.78.16 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?