Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

Comments

fix: optionally use storage new hostname#234

Merged
fenos merged 1 commit intomainfrom
storage/optionally-use-new-hostname
Jul 8, 2025
Merged

fix: optionally use storage new hostname#234
fenos merged 1 commit intomainfrom
storage/optionally-use-new-hostname

Conversation

@fenos
Copy link
Contributor

@fenos fenos commented Jul 8, 2025

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

Opt-in behaviour of using the new storage hostname

@fenos fenos force-pushed the storage/optionally-use-new-hostname branch from 75b6ac2 to c8eeba4 Compare July 8, 2025 11:08
Copy link
Member

@ivasilov ivasilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@itslenny itslenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works. Later when we're sure this is working well we can change the default value to true to make the new host the default, and users can still pass false to disable it.

@fenos fenos merged commit 0dee601 into main Jul 8, 2025
3 checks passed
@fenos fenos deleted the storage/optionally-use-new-hostname branch July 8, 2025 15:30
@kiwicopple
Copy link
Member

🎉 This PR is included in version 2.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants