Skip to content

fix: remove deuplicate slash in tus upload url generator #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

fix: remove deuplicate slash in tus upload url generator #801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/http/routes/tus/lifecycle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,8 @@ export function generateUrl(

const forwardedPath = req.headers['x-forwarded-prefix']
if (requestAllowXForwardedPrefix && typeof forwardedPath === 'string') {
basePath = forwardedPath + path
// Remove trailing slash from forwardedPath to avoid double slashes
Copy link

@ferhatelmas ferhatelmas Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar pattern could happen for signV4 of canonical request if this feature requestAllowXForwardedPrefix is enabled or a configuration value ending with a slash is given. I believe, as a result, it can cause SignatureDoesNotMatch errors

Copy link

@aantti aantti Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

basePath = forwardedPath.replace(/\/+$/, '') + path
}

const isSigned = req.url?.endsWith(SIGNED_URL_SUFFIX)
Expand Down Expand Up @@ -264,7 +265,7 @@ export async function onUploadFinish(rawReq: Request, upload: Upload) {
if (upload.metadata?.metadata) {
try {
customMd = JSON.parse(upload.metadata.metadata)
} catch (e) {
} catch {
// no-op
}
}
Expand Down
Loading