Skip to content

chore: drop crypto-js in favor of hardcoded vectors#885

Merged
ferhatelmas merged 1 commit intomasterfrom
ferhat/crypto-dep
Mar 3, 2026
Merged

chore: drop crypto-js in favor of hardcoded vectors#885
ferhatelmas merged 1 commit intomasterfrom
ferhat/crypto-dep

Conversation

@ferhatelmas
Copy link
Member

What kind of change does this PR introduce?

chore

What is the current behavior?

crypto-js is used only in tests for compatibility

What is the new behavior?

use crypto-js and produce the vectors and drop the dependency since not used anymore

Additional context

related to #525

related to #525

Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
@ferhatelmas ferhatelmas requested a review from a team as a code owner March 3, 2026 14:08
@coderabbitai
Copy link

coderabbitai bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Cache: Disabled due to Reviews > Disable Cache setting

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 85e6efe and 06469c1.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • package.json
  • src/test/auth-crypto.test.ts
💤 Files with no reviewable changes (1)
  • package.json

📝 Walkthrough

Summary by CodeRabbit

  • Chores

    • Removed CryptoJS dependency and associated type definitions from the project.
  • Tests

    • Updated authentication cryptography tests with predefined test data samples.
    • Refactored test cases to validate decryption using fixed ciphertext inputs.

Walkthrough

The changes remove the crypto-js package and its TypeScript type definitions from the project dependencies. Correspondingly, the test file is updated to remove CryptoJS imports and replace dynamic compatibility tests with static assertions. Two hardcoded ciphertext constants (legacyCiphertext and deterministicCiphertext) are introduced, and the test cases are refactored to verify decryption of these fixed inputs rather than testing encryption/decryption compatibility between different cryptographic implementations.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ferhatelmas ferhatelmas merged commit 228c507 into master Mar 3, 2026
2 checks passed
@ferhatelmas ferhatelmas deleted the ferhat/crypto-dep branch March 3, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants