-
-
Notifications
You must be signed in to change notification settings - Fork 273
feat(gotrue, supabase, supabase_flutter, realtime_client): Use web package to access web APIs #1135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 14036571806Details
💛 - Coveralls |
Vinzent03
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still a html import here: https://github.com/supabase/supabase-flutter/blob/fix/gotrue-web/packages/supabase_flutter/lib/src/local_storage_web.dart#L2-L2
and this comment: https://github.com/supabase/supabase-flutter/blob/fix/gotrue-web/packages/gotrue/lib/src/types/auth_state.dart#L8-L8 could probably be improved as well now.
I think changing this one should be its own PR as the API has slightly changed. It's not simple swaping in and out.
Fixed. |
|
From a quick look at the documentation it seems like a quick swap of the import and method names should be possible. You changed the behavior of the broadcast channel as well, so I don't quite get the differentiation to this migration here... Since this is a breaking change due to the changed dart sdk requirements, I would at least release this pr as a new minor version. |
What kind of change does this PR introduce?
This PR migrates gotrue to package:web.
Because of version constraints issues, this bumps the minimum Dart version to 3.3.0 and Flutter version to 3.19.0, which has been released in Feb 16, 2024.
What is the current behavior?
Uses the old html API, which causes analysis issue, and is not recommended to keep by the Flutter team.
What is the new behavior?
The new web package is used.