fix: Uri encode platform information #1196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vinzent03
changed the title
grdsdev
approved these changes
Jun 25, 2025
|
Hi @Vinzent03, do you have rights to publish a new minor version on pub.dev to include this patch ? It would fix issues related to accents like in French windows "Windows 11 Éducation" |
Collaborator
Author
|
Sadly not. @dshukertjr please release a new version as important fixes are already fixed but not released for a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
The platform information may contain non ASCII characters, which are not allowd in http headers.
What is the new behavior?
These strings are now url encoded to fix that.
Additional context
close #1192