fix(storage_client): Resolve MultipartRequest finalization error in retry mechanism #1208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etry mechanism When using StorageRetryController, failed uploads would trigger retries that attempted to reuse the same MultipartRequest object. Since MultipartRequest objects become finalized after the first send() call, subsequent retry attempts would throw "Can't finalize a finalized Request" StateError. This fix creates a fresh MultipartRequest for each retry attempt by introducing a createRequest() factory function that generates new request objects with all the necessary headers, files, and fields configured correctly. Fixes the retry functionality for file uploads with StorageRetryController, making it reliable for handling network failures during large file uploads. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Pull Request Test Coverage Report for Build 16878888589Details
💛 - Coveralls |
grdsdev
requested review from
Copilot,
Vinzent03 and
dshukertjr
and removed request for
Copilot and
Vinzent03
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical bug in the storage client's retry mechanism where MultipartRequest objects were being reused across retry attempts, causing "Can't finalize a finalized Request" errors. The solution creates a fresh MultipartRequest for each retry attempt by introducing a factory function that generates new request objects with identical configuration.
- Introduces a
createRequest()factory function to generate fresh MultipartRequest objects - Moves request creation inside the retry closure to ensure each attempt gets a new request
- Maintains all existing functionality while making retry mechanism reliable for file uploads
dshukertjr
approved these changes
Aug 14, 2025
grdsdev
deleted the
guilherme/clibs-287-supabase-flutter-storageretrycontroller-causes-cant-finalize
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When using
StorageRetryControllerwith file uploads, if the upload fails and triggers a retry, the SDK throws aBad state: Can't finalize a finalized Requesterror. This occurs because the retry mechanism attempts to reuse an already-finalizedMultipartRequestobject.The issue happens in the
_handleMultipartRequestmethod infetch.dartwhere:MultipartRequest(which finalizes it)MultipartRequestobjects cannot be finalized twice, this throws aStateErrorThis makes the retry functionality unusable for multipart uploads, particularly problematic for large file uploads on unstable connections.
What is the new behavior?
The retry logic now creates a fresh
MultipartRequestfor each retry attempt. This is accomplished by:createRequest()factory function that generates newMultipartRequestobjects with all necessary configurationNow failed uploads can be successfully retried without encountering finalization errors, making
StorageRetryControllerreliable for handling network failures during file uploads.Additional context
Related to the retry functionality introduced in previous versions where this edge case wasn't properly handled.