fix(postgrest): URL replacement logic in query builder #1228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grdsdev
changed the title
|
Hi @sbutlerjr thanks for opening this fix, can you also include a unit test for asserting this behavior? |
Pull Request Test Coverage Report for Build 18090604237Details
💛 - Coveralls |
|
Hi @grdsdev Tests added |
grdsdev
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Resolves: #1227
Prior bug omitted passing onConflict through to on_conflict if the value data was a list.
What is the current behavior?
on_conflict was omitted from the REST URL if the data was a list
What is the new behavior?
Works correctly with POSTGrest on_conflict docs and passes the columns and on_conflict properties in the URL.