feat(realtime): add explicit REST API call method for broadcast messages #1253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new `httpSend` method to RealtimeChannel class that explicitly uses the REST API endpoint for sending broadcast messages, regardless of WebSocket connection state. Changes: - Added `httpSend` method with proper error handling and timeout support - Added deprecation warning to `send` method when falling back to REST - Comprehensive test coverage for the new method This addresses the issue where users may unknowingly use REST API fallback when WebSocket is not connected. The new method provides explicit control over message delivery mechanism. Ported from: supabase/supabase-js#1751 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Pull Request Test Coverage Report for Build 18383152561Details
💛 - Coveralls |
Vinzent03
requested changes
Oct 9, 2025
| if (e is TimeoutException) { | ||
| rethrow; | ||
| } | ||
| throw Exception(e.toString()); |
There was a problem hiding this comment.
Im unsure what the reason for this catch block is. I would just remove it as it either just rethrows the timeout or stringifies the exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
httpSendmethod to theRealtimeChannelclass that explicitly uses the REST API endpoint for sending broadcast messages, regardless of WebSocket connection state.Changes
httpSendmethod with proper error handling and timeout supportsendmethod when falling back to RESTMotivation
Currently, the
sendmethod automatically falls back to using the REST API when the WebSocket connection is not available. However, this behavior is implicit and users may not be aware they are using REST instead of WebSocket.This change provides an explicit method for REST delivery, giving users more control over their message delivery mechanism and preparing for future deprecation of the implicit fallback behavior.
Test Plan
httpSendmethod covering:Related
Ported from: supabase/supabase-js#1751
🤖 Generated with Claude Code