Skip to content

Conversation

@lourd
Copy link
Contributor

@lourd lourd commented Oct 17, 2024

I just ran into the issue described in supabase/realtime#282 — the subscribe does not mean that I'm successfully subscribed to postgres_changes - instead I need to listen on 'system' messages for that confirmation, checking the extension and status properties, as @chasers described in that thread.

I searched around to see if the types for @supabase/supabase-js to include 'system', and was happily surprised to see that @filipecabaco added it in supabase/realtime-js#422 last month.

Then I was confused to discover that this module hadn't been updated since then.

Thankfully a simple fix! Just updating these version numbers. I went ahead and update the other supabase modules that are behind their latest versions, too.

It would be ideal if this module was automatically updated when its supabase sub-modules are updated, as I think everyone is mostly using them via this module, as the docs say to do. Or perhaps a more lenient version constraint at least so users can more easily update them on their own?

@grdsdev grdsdev requested a review from soedirgo October 17, 2024 21:05
@soedirgo soedirgo enabled auto-merge (squash) October 18, 2024 03:24
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11396880194

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.038%

Totals Coverage Status
Change from base Build 11254232747: 0.0%
Covered Lines: 99
Relevant Lines: 129

💛 - Coveralls

@soedirgo soedirgo merged commit 39ba2c5 into supabase:master Oct 18, 2024
1 check passed
@lourd lourd deleted the patch-1 branch October 18, 2024 05:46
@lourd
Copy link
Contributor Author

lourd commented Oct 18, 2024

Thanks @soedirgo! What's an ETA on publishing a new version you think?

@soedirgo
Copy link
Member

Oops, meant to release a new version immediately - gimme a moment

@soedirgo soedirgo mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants