Skip to content

feat: Realtime using accessToken callback for auth #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2024
Merged

feat: Realtime using accessToken callback for auth #1320

merged 2 commits into from
Dec 5, 2024

Conversation

@filipecabaco
Copy link
Member

@filipecabaco filipecabaco commented Dec 3, 2024

What kind of change does this PR introduce?

Realtime using accessToken callback for auth

@coveralls
Copy link

coveralls commented Dec 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12179605440

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.6%) to 67.633%
Files with Coverage Reduction New Missed Lines %
src/SupabaseClient.ts 1 67.27%
Totals Coverage Status
Change from base Build 12059909571: 1.6%
Covered Lines: 99
Relevant Lines: 128
💛 - Coveralls

grdsdev
grdsdev requested changes Dec 4, 2024
View reviewed changes
@grdsdev grdsdev mentioned this pull request Dec 4, 2024
Merged
@filipecabaco filipecabaco marked this pull request as ready for review December 5, 2024 14:28
@filipecabaco filipecabaco merged commit 88a44df into master Dec 5, 2024
1 check passed
@filipecabaco filipecabaco deleted the feat/realtime-set-auth branch December 5, 2024 15:00
@felixgabler felixgabler mentioned this pull request Dec 5, 2024
Merged
6 tasks
@gdaybrice
Copy link
Contributor

gdaybrice commented Dec 5, 2024

The latest release is causing a "Maximum call stack size exceeded" error.

Unhandled Runtime Error

RangeError: Maximum call stack size exceeded

Call Stack
<unknown>
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (23:62)
push.[project]/node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/dist/module/SupabaseClient.js [app-client] (ecmascript).__awaiter
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (23:62)
RealtimeClient._getAccessToken [as accessToken]
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (268:32)
RealtimeClient.<anonymous>
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (270:25)
<unknown>
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (23:62)
push.[project]/node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/dist/module/SupabaseClient.js [app-client] (ecmascript).__awaiter
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (23:62)
RealtimeClient._getAccessToken [as accessToken]
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (268:32)
RealtimeClient.<anonymous>
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (270:25)
<unknown>
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (23:62)
push.[project]/node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/dist/module/SupabaseClient.js [app-client] (ecmascript).__awaiter
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (23:62)
RealtimeClient._getAccessToken [as accessToken]
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (268:32)
RealtimeClient.<anonymous>
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (270:25)
<unknown>
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (23:62)
push.[project]/node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/dist/module/SupabaseClient.js [app-client] (ecmascript).__awaiter
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (23:62)
RealtimeClient._getAccessToken [as accessToken]
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (268:32)
RealtimeClient.<anonymous>
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (270:25)
<unknown>
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (23:62)
push.[project]/node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/dist/module/SupabaseClient.js [app-client] (ecmascript).__awaiter
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (23:62)
RealtimeClient._getAccessToken [as accessToken]
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (268:32)
RealtimeClient.<anonymous>
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (270:25)
<unknown>
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (23:62)
push.[project]/node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/dist/module/SupabaseClient.js [app-client] (ecmascript).__awaiter
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (23:62)
RealtimeClient._getAccessToken [as accessToken]
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (268:32)
RealtimeClient.<anonymous>
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (270:25)
<unknown>
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (23:62)
push.[project]/node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/dist/module/SupabaseClient.js [app-client] (ecmascript).__awaiter
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (23:62)
RealtimeClient._getAccessToken [as accessToken]
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (268:32)
RealtimeClient.<anonymous>
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (270:25)
<unknown>
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (23:62)
push.[project]/node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/dist/module/SupabaseClient.js [app-client] (ecmascript).__awaiter
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (23:62)
RealtimeClient._getAccessToken [as accessToken]
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (268:32)
RealtimeClient.<anonymous>
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (270:25)
<unknown>
node_modules/.pnpm/@[email protected]/node_modules/@supabase/supabase-js/src/SupabaseClient.ts (23:62)

@gdaybrice gdaybrice mentioned this pull request Dec 5, 2024
Closed
filipecabaco added a commit that referenced this pull request Dec 5, 2024
@filipecabaco
Revert "feat: Realtime using accessToken callback for auth (#1320)"
ba7b21f 
This reverts commit 88a44df.
@filipecabaco filipecabaco mentioned this pull request Dec 5, 2024
Merged
filipecabaco added a commit that referenced this pull request Dec 5, 2024
@filipecabaco
Revert "feat: Realtime using accessToken callback for auth (#1320)" (#…
b9c86f5 
…1323)

This reverts commit 88a44df.
@AbdurrehmanSubhani AbdurrehmanSubhani mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grdsdev grdsdev grdsdev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@filipecabaco @coveralls @gdaybrice @grdsdev