fix: make Authorization header check case-insensitive #1528
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix issue supabase#1043 where custom Authorization headers were checked case-sensitively - HTTP headers should be case-insensitive according to RFC standards - Replace exact key match with case-insensitive check using Object.keys().some() - This allows headers like 'authorization', 'Authorization', 'AUTHORIZATION' to work correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1043
This PR makes the Authorization header detection case-insensitive, which is the correct behavior according to HTTP RFC standards. Previously, the code only checked for the exact string 'Authorization' in headers, but HTTP headers should be case-insensitive.
Changes Made
'Authorization' in this.headerscheck with case-insensitiveObject.keys(this.headers).some(key => key.toLowerCase() === 'authorization')Testing
Root Cause
The issue was introduced in the hasCustomAuthorizationHeader check which was meant to detect custom auth headers but was using case-sensitive string matching instead of proper case-insensitive header handling.
Additional Notes
This is a small but important fix that improves compatibility with various HTTP client implementations that may use different casing for the Authorization header.
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]