-
Notifications
You must be signed in to change notification settings - Fork 483
feat(postgrest): add embeded functions type inference #1632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
avallete
wants to merge
15
commits into
master
Choose a base branch
from
feat/add-embeded-functions-type-inference
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,795
−735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Keeps the new tests, use the old types, ensure the new behavior types are retro-compatibles To do so we've first checkout src/ to match current master ran the test and extracted all errors Then restored the new src/ ran the tests extracted all errors Then, compare the both to ensure they was no differences (only one is about filtering after rpc call which is expected) Commented out the failing scenarios for now, they'll be uncommented when we release the new postgres-meta version with the new SetofOptions available, at this point they can all be uncommented and will pass
dac034f
to
4b3ba3c
Compare
@supabase/auth-js
@supabase/functions-js
@supabase/postgrest-js
@supabase/realtime-js
@supabase/storage-js
@supabase/supabase-js
commit: |
soedirgo
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Rework and migration of: supabase/postgrest-js#632 to the new monorepo
We want to first release the types inference changes first for two reasons:
What changed?
queries
/rpc
and prepare to work with the newpostgrest-meta
introspection which will allowssetof
returning function to be properly handled cf this PR. Those changes will include:SetofOptions
fields in the functions definitions so we can loop for relationship inselect
embed functionspostgrest
functions calls errors when possible allowing users to see in advance when postgrest won't be able to discriminate between two functions with similar calls, or when a function can't be used as embed function.postgrest-js
andsupabase-js
to reduce duplication but maintain consitency.rpc
typing logic into it's own file, also extracted the other types previously duplicated withinsupabase-js
so we can just copy / paste the files over withinsupabase-js/src/lib/rest/types/common
to ensure consistency.postbuild
script topostgrest-js
that takes those common types used in both packages and copy them over. Makingpostgrest-js
the source of truth, andsupabase-js
a derivative.Why was this change needed?
rpc
calls really properly. With those type inference changes, along with the new generated types, we'll have a much more closer to runtime type generation.This will close those (some more might be in backlog):
Closes #1366 #1365 #1364 #1641
🔄 Breaking changes
📋 Checklist
<type>(<scope>): <description>
npx nx format
to ensure consistent code formatting