Skip to content

Conversation

o-santi
Copy link
Contributor

@o-santi o-santi commented Sep 19, 2025

What kind of change does this PR introduce?

Fix type definitions in storage.

What is the current behavior?

mypy throws errors in both src/storage and tests.

What is the new behavior?

mypy passes for both. Also took the opportunity to improve make default message for storage.

@o-santi o-santi requested a review from silentworks September 19, 2025 15:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 17862390832

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 15 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.06%) to 93.795%

Files with Coverage Reduction New Missed Lines %
tests/utils.py 1 54.55%
src/storage3/_sync/file_api.py 7 96.0%
src/storage3/_async/file_api.py 7 96.0%
Totals Coverage Status
Change from base Build 17808809082: 0.06%
Covered Lines: 8616
Relevant Lines: 9186

💛 - Coveralls

@o-santi o-santi requested a review from grdsdev September 19, 2025 15:24
@o-santi o-santi merged commit ea44ab6 into supabase:main Sep 19, 2025
9 checks passed
@github-actions github-actions bot mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants