Skip to content

Conversation

@o-santi
Copy link
Contributor

@o-santi o-santi commented Nov 3, 2025

What kind of change does this PR introduce?

with_config only accepts kwargs from pydantic 2.7.0 onward, so our code is not compatible with those versions, even though it is advertised on the pydantic.toml. To fix it, we pass in the whole config dict instead.

Fixes #1291.

Additional context

We do need a cutoff date to stop supporting old pydantic versions. Not sure how to decide on that though.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 19035673844

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 92.567%

Files with Coverage Reduction New Missed Lines %
src/supabase_auth/types.py 2 98.86%
Totals Coverage Status
Change from base Build 18981387503: 0.0%
Covered Lines: 8755
Relevant Lines: 9458

💛 - Coveralls

@o-santi o-santi merged commit 78b6d53 into main Nov 3, 2025
11 checks passed
@o-santi o-santi deleted the auth/fix_with_config branch November 3, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pydantic dependency issue

4 participants