Skip to content

Conversation

@o-santi
Copy link
Contributor

@o-santi o-santi commented Nov 3, 2025

What kind of change does this PR introduce?

After #1249, the storage client no longer should read the HTTPx client's base_url, but should instead read self._base_url, as to not mutate objects passed in as shared. However, we are still reading the wrong URL inside create_signed_upload_url.

The tests were passing before because they were also reading the same wrong variable, so the mistakes cancelled out.

Fixes #1294

Additional context

This is certainly confusing. I want to get rid of external httpx clients for v3.0 as quickly as possible.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 19042484437

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.567%

Totals Coverage Status
Change from base Build 19037859464: 0.0%
Covered Lines: 8755
Relevant Lines: 9458

💛 - Coveralls

@o-santi o-santi merged commit a81b074 into main Nov 3, 2025
14 of 20 checks passed
@o-santi o-santi deleted the storage/fix-create-signed-url branch November 3, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Storage HTTPx client doesn't have a base_url

5 participants