Skip to content

fix: Types to use Option[T] #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 15, 2024
Merged

fix: Types to use Option[T] #960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0215a73
fix: Types to use Option[T]
juancarlospaco Oct 8, 2024
9cae146
fix: Types to use Option[T]
juancarlospaco Oct 8, 2024
e12ab78
fix: Types to use Option[T]
juancarlospaco Oct 8, 2024
3be5a23
fix: Types to use Option[T]
juancarlospaco Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions supabase/_async/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def __init__(
self,
supabase_url: str,
supabase_key: str,
options: Union[ClientOptions, None] = None,
options: Optional[ClientOptions] = None,
):
"""Instantiate the client.

Expand Down Expand Up @@ -97,7 +97,7 @@ async def create(
cls,
supabase_url: str,
supabase_key: str,
options: Union[ClientOptions, None] = None,
options: Optional[ClientOptions] = None,
):
auth_header = options.headers.get("Authorization") if options else None
client = cls(supabase_url, supabase_key, options)
Expand Down Expand Up @@ -278,9 +278,7 @@ def _init_postgrest_client(
def _create_auth_header(self, token: str):
return f"Bearer {token}"

def _get_auth_headers(
self, authorization: Union[str, None] = None
) -> Dict[str, str]:
def _get_auth_headers(self, authorization: Optional[str] = None) -> Dict[str, str]:
if authorization is None:
authorization = self.options.headers.get(
"Authorization", self._create_auth_header(self.supabase_key)
Expand All @@ -293,7 +291,7 @@ def _get_auth_headers(
}

def _listen_to_auth_events(
self, event: AuthChangeEvent, session: Union[Session, None]
self, event: AuthChangeEvent, session: Optional[Session]
):
access_token = self.supabase_key
if event in ["SIGNED_IN", "TOKEN_REFRESHED", "SIGNED_OUT"]:
Expand All @@ -310,7 +308,7 @@ def _listen_to_auth_events(
async def create_client(
supabase_url: str,
supabase_key: str,
options: Union[ClientOptions, None] = None,
options: Optional[ClientOptions] = None,
) -> AsyncClient:
"""Create client function to instantiate supabase client like JS runtime.

Expand Down
12 changes: 5 additions & 7 deletions supabase/_sync/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def __init__(
self,
supabase_url: str,
supabase_key: str,
options: Union[ClientOptions, None] = None,
options: Optional[ClientOptions] = None,
):
"""Instantiate the client.

Expand Down Expand Up @@ -96,7 +96,7 @@ def create(
cls,
supabase_url: str,
supabase_key: str,
options: Union[ClientOptions, None] = None,
options: Optional[ClientOptions] = None,
):
auth_header = options.headers.get("Authorization") if options else None
client = cls(supabase_url, supabase_key, options)
Expand Down Expand Up @@ -277,9 +277,7 @@ def _init_postgrest_client(
def _create_auth_header(self, token: str):
return f"Bearer {token}"

def _get_auth_headers(
self, authorization: Union[str, None] = None
) -> Dict[str, str]:
def _get_auth_headers(self, authorization: Optional[str] = None) -> Dict[str, str]:
if authorization is None:
authorization = self.options.headers.get(
"Authorization", self._create_auth_header(self.supabase_key)
Expand All @@ -292,7 +290,7 @@ def _get_auth_headers(
}

def _listen_to_auth_events(
self, event: AuthChangeEvent, session: Union[Session, None]
self, event: AuthChangeEvent, session: Optional[Session]
):
access_token = self.supabase_key
if event in ["SIGNED_IN", "TOKEN_REFRESHED", "SIGNED_OUT"]:
Expand All @@ -308,7 +306,7 @@ def _listen_to_auth_events(
def create_client(
supabase_url: str,
supabase_key: str,
options: Union[ClientOptions, None] = None,
options: Optional[ClientOptions] = None,
) -> SyncClient:
"""Create client function to instantiate supabase client like JS runtime.

Expand Down