Skip to content

fix(auth): expose KeychainLocalStorage with default init params #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2024
Merged

fix(auth): expose KeychainLocalStorage with default init params #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions Sources/Auth/Storage/AuthLocalStorage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,8 @@ public protocol AuthLocalStorage: Sendable {

extension AuthClient.Configuration {
#if !os(Linux) && !os(Windows)
public static let defaultLocalStorage: any AuthLocalStorage = KeychainLocalStorage(
service: "supabase.gotrue.swift",
accessGroup: nil
)
public static let defaultLocalStorage: any AuthLocalStorage = KeychainLocalStorage()
#elseif os(Windows)
public static let defaultLocalStorage: any AuthLocalStorage =
WinCredLocalStorage(service: "supabase.gotrue.swift")
public static let defaultLocalStorage: any AuthLocalStorage = WinCredLocalStorage()
#endif
}
3 changes: 2 additions & 1 deletion Sources/Auth/Storage/KeychainLocalStorage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
#if !os(Windows) && !os(Linux)
import Foundation

/// ``AuthLocalStorage`` implementation using Keychain. This is the default local storage used by the library.
public struct KeychainLocalStorage: AuthLocalStorage {
private let keychain: Keychain

public init(service: String, accessGroup: String?) {
public init(service: String = "supabase.gotrue.swift", accessGroup: String? = nil) {
keychain = Keychain(service: service, accessGroup: accessGroup)
}

Expand Down
2 changes: 1 addition & 1 deletion Sources/Auth/Storage/WinCredLocalStorage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
private let credentialType: DWORD
private let credentialPersistence: DWORD

public init(service: String) {
public init(service: String = "supabase.gotrue.swift") {
self.service = service
credentialType = DWORD(CRED_TYPE_GENERIC)
credentialPersistence = DWORD(CRED_PERSIST_LOCAL_MACHINE)
Expand Down