make geonames search param configurable#3198
Merged
petrjasek merged 2 commits intosuperdesk:release/2.11from Apr 14, 2026
Merged
make geonames search param configurable#3198petrjasek merged 2 commits intosuperdesk:release/2.11from
petrjasek merged 2 commits intosuperdesk:release/2.11from
Conversation
so we can change it to `name_startsWith` for ANSA to restore previous behaviour. SDANSA-582
Contributor
There was a problem hiding this comment.
Pull request overview
Adds configurability for the GeoNames search query parameter so deployments (e.g., ANSA) can switch from name to name_startsWith and restore prior autocomplete behavior.
Changes:
- Introduces
GEONAMES_SEARCH_PARAMsetting (env-configurable) with defaultname. - Updates places autocomplete to use the configured GeoNames search parameter when calling the GeoNames
searchendpoint.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| superdesk/places/places_autocomplete.py | Uses configurable GeoNames query param key when constructing search request parameters. |
| superdesk/default_settings.py | Adds GEONAMES_SEARCH_PARAM default setting and documentation comment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BrianMwangi21
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so we can change it to
name_startsWithfor ANSAto restore previous behaviour.
SDANSA-582
Purpose
What has changed
Steps to test
Resolves: #[issue-number]