Open
Conversation
Contributor
blythed
force-pushed
the
feature/components-table
branch
5 times, most recently
from
e4289dd to
2b2720e
Compare
blythed
force-pushed
the
feature/components-table
branch
from
2b2720e to
cb3451b
Compare
jieguangzhou
reviewed
Sep 4, 2025
Contributor
jieguangzhou
left a comment
jieguangzhou
left a comment
There was a problem hiding this comment.
Could you also test it on postgresql also, Because earlier some refactor UTs passed, but PostgreSQL tests didn’t.
Comment on lines
45
to
51
| t = self.db['Deployment'] | ||
| components = ( | ||
| t.filter(t['parent'] == 'VectorIndex') | ||
| .select('component', 'uuid', 'identifier') | ||
| .execute() | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
We also need to do this in other services, for example CDC, Cronjob, etc...
Comment on lines
+584
to
+585
| r = {**r, 'version': 0, 'uuid': t.uuid} | ||
| self.create_component(r) |
Contributor
There was a problem hiding this comment.
We’ve already imported the schema, so it seems like create_component isn’t needed in the create method anymore. This is just for creating the schema of the data table, right?
superduper/components/component.py
Outdated
| for v in item.values(): | ||
| _set_context(v, context) | ||
|
|
||
| _set_context(self, self.uuid) |
Contributor
There was a problem hiding this comment.
If different parent components share the same subcomponent, then the context would become ambiguous, right?
blythed
force-pushed
the
feature/components-table
branch
9 times, most recently
from
7b046a9 to
b3aeb0a
Compare
blythed
force-pushed
the
feature/components-table
branch
from
b3aeb0a to
7fc1b2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2915.