Skip to content

[ETHEREUM-CONTRACTS] remove footgun from CFASuperAppBase #2043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

[ETHEREUM-CONTRACTS] remove footgun from CFASuperAppBase #2043

wants to merge 4 commits into from

Conversation

d10r
Copy link
Collaborator

@d10r d10r commented Dec 16, 2024 •
edited
Loading

  • explicit hook for deleted outflow

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 16, 2024 •
edited by d10r
Loading

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@d10r d10r force-pushed the cfa_hook_no_footgun branch from 9fd6502 to 5519053 Compare January 2, 2025 14:48
@d10r d10r changed the title [ETHEREUM-CONTRACTS] CFASuperAppBase: explicit hook for deleted outflow [ETHEREUM-CONTRACTS] replace CFASuperAppBase with SuperAppBase Jan 2, 2025
@d10r d10r changed the title [ETHEREUM-CONTRACTS] replace CFASuperAppBase with SuperAppBase [ETHEREUM-CONTRACTS] make CFASuperAppBase safer Jan 2, 2025
@d10r d10r changed the title [ETHEREUM-CONTRACTS] make CFASuperAppBase safer [ETHEREUM-CONTRACTS] remove footgun from CFASuperAppBase Jan 2, 2025
@d10r d10r changed the base branch from dev-next to dev January 2, 2025 16:35
@d10r d10r marked this pull request as ready for review January 2, 2025 19:47
@d10r d10r requested a review from hellwolf as a code owner January 2, 2025 19:47
@hellwolf hellwolf marked this pull request as draft March 12, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hellwolf hellwolf Awaiting requested review from hellwolf hellwolf is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@d10r @hellwolf