fix: prevent gasLimit=0 for EOA wallets during isEOA loading#861
Merged
kasparkallas merged 2 commits intomasterfrom Mar 31, 2026
Merged
fix: prevent gasLimit=0 for EOA wallets during isEOA loading#861kasparkallas merged 2 commits intomasterfrom
kasparkallas merged 2 commits intomasterfrom
Conversation
The `!isEOA` check treated `null` (loading/error) the same as `false`, causing EOA wallets to get gasLimit=0 before the isEOA query resolved. SDK-core's Operation class converts 0 to BigNumber(0) which is truthy, skipping gas estimation and sending transactions with zero gas. Using `isEOA === false` ensures gasLimit=0 is only set for confirmed smart contract wallets. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isEOAisboolean | null— it'snullwhile thegetCode()query is loading or on error!null === true, so EOA wallets were gettinggasLimit = 0before the query resolved0toBigNumber(0)which is truthy, skipping gas estimation entirelygasLimit = 0→ "Intrinsic gas too low" on Polygon and BaseisEOA === falseensures gasLimit=0 only for confirmed smart contract walletsTest plan
🤖 Generated with Claude Code