[Do not merge] Add a garbage collector for old records #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Somtochi Onyekwere <[email protected]>
Signed-off-by: Somtochi Onyekwere <[email protected]>
Signed-off-by: Somtochi Onyekwere <[email protected]>
Signed-off-by: Somtochi Onyekwere <[email protected]>
Signed-off-by: Somtochi Onyekwere <[email protected]>
gorbak25
reviewed
Feb 3, 2026
gorbak25
reviewed
Feb 3, 2026
gorbak25
reviewed
Feb 3, 2026
gorbak25
reviewed
Feb 3, 2026
Contributor
gorbak25
left a comment
gorbak25
left a comment
There was a problem hiding this comment.
LGTM. Please add the tripwire so the reaper doesn't linger during tests/benchmarks.
Signed-off-by: Somtochi Onyekwere <[email protected]>
gorbak25
approved these changes
Feb 3, 2026
Signed-off-by: Somtochi Onyekwere <[email protected]>
Signed-off-by: Somtochi Onyekwere <[email protected]>
Signed-off-by: Somtochi Onyekwere <[email protected]>
Signed-off-by: Somtochi Onyekwere <[email protected]>
Signed-off-by: Somtochi Onyekwere <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CR-SQLite, like most CRDT systems, retains metadata in clock tables for each primary key even after a row has been deleted. For tables where deleted rows are never re-inserted, this metadata can accumulate unnecessarily over time.
This pull request allows users to configure specific tables and a retention period, after which metadata associated with primary keys deleted before that period can be safely removed.
The catch here is that if these keys are re-inserted before all the nodes delete associated metadata, it could lead to some inconsistencies.So only enable this for tables wheree primary keys are never re-inserted after deletion.