Remove serde_with
#419
Open
Remove serde_with
#419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
Author
|
I added some simple tests for ApiConfig deserialization and fixed the issues. |
somtochiama
reviewed
Feb 3, 2026
Contributor
somtochiama
left a comment
somtochiama
left a comment
There was a problem hiding this comment.
somehow got things stuck in an infinite loop by specifying bind_addr instead of addr.
[api]
bind_addr = "127.0.0.1:8080"
[[api.pg]]
bind_addr = "127.0.0.1:5470"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serde_withpulled in an old version of base64 (unused) as well as 4 crates purely for macro parsing that aren't shared with any other crate in the workspace, this just replaces it with inline code that replicates the functionality.